netdev - Re: [PATCH net-next 07/14] devlink: drop the filter argument from devlinks_xa_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7VPgXHep5We0TQQ@nanopsycho>
Date:   Wed, 4 Jan 2023 11:05:53 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jacob.e.keller@...el.com
Subject: Re: [PATCH net-next 07/14] devlink: drop the filter argument from
 devlinks_xa_find_get

Wed, Jan 04, 2023 at 05:16:29AM CET, kuba@...nel.org wrote:
>Looks like devlinks_xa_find_get() was intended to get the mark
>from the @filter argument. It doesn't actually use @filter, passing
>DEVLINK_REGISTERED to xa_find_fn() directly. Walking marks other
>than registered is unlikely so drop @filter argument completely.
>
>Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>