netdev - Re: [PATCH net-next 1/2] net: hns3: support wake on lan configuration and query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7WUdLFEj9k6UTpD@lunn.ch>
Date:   Wed, 4 Jan 2023 16:00:04 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Hao Lan <lanhao@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, yisen.zhuang@...wei.com,
        salil.mehta@...wei.com, edumazet@...gle.com, pabeni@...hat.com,
        richardcochran@...il.com, shenjian15@...wei.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: hns3: support wake on lan
 configuration and query

On Wed, Jan 04, 2023 at 08:57:40PM +0800, Hao Lan wrote:
> Hi Andrew,
> Thank you for reviewing our code. Thank you very much.
> You're right, such as WAKE_PHY, WAKE_CAST, these are implemented
> in the kernel, they are ABI, they will never change, we use it
> will directly simplify our code, your advice is very useful, thank
> you very much for your advice.
> However, these interfaces serve as a buffer between our firmware
> and the linux community. Considering our interface expansion and
> evolution, we may add some private modes in the future.

You cannot add private WOL modes, since they will be unusable without
ethtool support. And to add ethtool support, they need to be
public. And to make them public, you just add more WAKE_ macros.  Just
make sure the new modes you add are well described, so other drivers
can also implement them.

	Andrew