netdev - Re: [PATCH net-next 1/2] macsec: add support for IFLA_MACSEC_OFFLOAD in macsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7Wvx8BSBegYLvTi@nanopsycho>
Date:   Wed, 4 Jan 2023 17:56:39 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     ehakim@...dia.com
Cc:     netdev@...r.kernel.org, raeds@...dia.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        sd@...asysnail.net, atenart@...nel.org
Subject: Re: [PATCH net-next 1/2] macsec: add support for IFLA_MACSEC_OFFLOAD
 in macsec_changelink

Wed, Jan 04, 2023 at 08:46:50AM CET, ehakim@...dia.com wrote:
>From: Emeel Hakim <ehakim@...dia.com>
>
>Add support for changing Macsec offload selection through the
>netlink layer by implementing the relevant changes in
>macsec_changelink.
>
>Since the handling in macsec_changelink is similar to macsec_upd_offload,
>update macsec_upd_offload to use a common helper function to avoid
>duplication.
>
>Example for setting offload for a macsec device:
>    ip link set macsec0 type macsec offload mac
>
>Reviewed-by: Raed Salem <raeds@...dia.com>
>Signed-off-by: Emeel Hakim <ehakim@...dia.com>

Emeel, I don't follow, You had version v5 submitted the last time. All
of the sudden, you now dropped both versioning in the tag  and changelog
from this patchset? Could you please add it and resubmit? Also it is
a good practise to put a cover letter when sending multiple patches in
a series, would be nice if you have it here too.

Thanks!