netdev - Re: [PATCH net] caif: fix memory leak in cfctrl_linkup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7W2hlf5+rhc93Uy@nanopsycho>
Date:   Wed, 4 Jan 2023 18:25:26 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        wsa+renesas@...g-engineering.com, sjur.brandeland@...ricsson.com,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net] caif: fix memory leak in cfctrl_linkup_request()

Wed, Jan 04, 2023 at 07:51:46AM CET, shaozhengchao@...wei.com wrote:
>When linktype is unknown or kzalloc failed in cfctrl_linkup_request(),
>pkt is not released. Add release process to error path.
>
>Fixes: b482cd2053e3 ("net-caif: add CAIF core protocol stack")
>Fixes: 8d545c8f958f ("caif: Disconnect without waiting for response")
>Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>