netdev - Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7XK3eUAzVbwMNXR@gmx.fr>
Date:   Wed, 4 Jan 2023 14:52:13 -0400
From:   Jamie Gloudon <jamie.gloudon@....fr>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
        netdev@...r.kernel.org, sasha.neftin@...el.com,
        Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised
 Support

On Wed, Jan 04, 2023 at 06:44:09PM +0100, Andrew Lunn wrote:
> > > I don't know this driver at all. What i don't see anywhere here is
> > > using the results of the pause auto-neg. Is there some code somewhere
> > > that looks at the local and link peer advertising values and runs a
> > > resolve algorithm to determine what pause should be used, and program
> > > it into the MAC?
> > > 
> > >     Andrew
> > This is a old patch i had laying around, If i remember correctly, phy->autoneg_advertised plugs in "Link partner
> > advertised pause frame use link" line in ethtool everytime the nic renegotiate.
> 
> Hi Jamie
> 
> Could you point me at the code which interprets the results of the
> auto neg and configures the MAC for the correct pause.
> 
> Thanks
> 	Andrew
Oh I now understand what you're saying. No clue. The guys at intel should have a better idea. Btw my old nic is not working anymore, Gosh!