[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <cover.1672865629.git.christophe.jaillet@wanadoo.fr>
Date: Wed, 4 Jan 2023 22:05:31 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
netdev@...r.kernel.org,
Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: [PATCH net-next 0/3] ezchip: Simplify some code
Theses patches (at least 1 and 2) can be seen as an RFC for net MAINTAINERS
get see if they see any interest in:
- axing useless netif_napi_del() calls, when free_netdev() is called just
after. (patch 1)
- simplifying code with axing the error handling path of the probe and the
remove function in favor of using devm_ functions (patch 2)
or
if it doesn't not worth it and MAINTAINERS' time can be focused on more
interesting topics than checking what is in fact only code clean-ups.
The rational for patch 1 is based on Jakub's comment [1].
free_netdev() already cleans up NAPIs (see [2]).
CJ
[1]: https://lore.kernel.org/all/20221221174043.1191996a@kernel.org/
[2]: https://elixir.bootlin.com/linux/v6.2-rc1/source/net/core/dev.c#L10710
Christophe JAILLET (3):
ezchip: Remove some redundant clean-up functions
ezchip: Switch to some devm_ function to simplify code
ezchip: Further clean-up
drivers/net/ethernet/ezchip/nps_enet.c | 47 ++++++--------------------
1 file changed, 10 insertions(+), 37 deletions(-)
--
2.34.1
Powered by blists - more mailing lists