| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230104215949.529093-1-sdf@google.com>
Date: Wed, 4 Jan 2023 13:59:32 -0800
From: Stanislav Fomichev <sdf@...gle.com>
To: bpf@...r.kernel.org
Cc: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
martin.lau@...ux.dev, song@...nel.org, yhs@...com,
john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com,
haoluo@...gle.com, jolsa@...nel.org,
David Ahern <dsahern@...il.com>,
Jakub Kicinski <kuba@...nel.org>,
Willem de Bruijn <willemb@...gle.com>,
Jesper Dangaard Brouer <brouer@...hat.com>,
Anatoly Burakov <anatoly.burakov@...el.com>,
Alexander Lobakin <alexandr.lobakin@...el.com>,
Magnus Karlsson <magnus.karlsson@...il.com>,
Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net,
netdev@...r.kernel.org
Subject: [PATCH bpf-next v6 00/17] xdp: hints via kfuncs
Please see the first patch in the series for the overall
design and use-cases.
See the following email from Toke for the per-packet metadata overhead:
https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798
Recent changes:
- Reject dev-bound progs at tc (Martin)
- Reuse __bpf_prog_offload_destroy instead of adding
__bpf_prog_dev_bound_destroy (Marin)
- Drop a bunch of unnecessary NULL checks (Martin)
- Fix compilation of xdp_hw_metadata (Martin and thank you David for the hints)
- Move bpf_dev_bound_kfunc_check into offload.c (Martin)
- Swap "ip netns del" and close_netns in the selftest (Martin)
- Move some code out of bpf_devs_lock (Martin)
- Remove some excessive gotos (Martin)
- Trigger bpf_prog_dev_bound_inherit for BPF_PROG_TYPE_EXT only when
the destination program is dev-bound (Martin)
- Document @xdp_metadata_ops (David)
- Use :identifiers: when referencing metadata kfuns in the doc (David)
- Spelling and teletyping fixes for the doc (David)
- Add a note about xsk_umem__get_data and METADATA_SIZE (David)
Prior art (to record pros/cons for different approaches):
- Stable UAPI approach:
https://lore.kernel.org/bpf/20220628194812.1453059-1-alexandr.lobakin@intel.com/
- Metadata+BTF_ID appoach:
https://lore.kernel.org/bpf/166256538687.1434226.15760041133601409770.stgit@firesoul/
- v5:
https://lore.kernel.org/bpf/20221220222043.3348718-1-sdf@google.com/
- v4:
https://lore.kernel.org/bpf/20221213023605.737383-1-sdf@google.com/
- v3:
https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.com/
- v2:
https://lore.kernel.org/bpf/20221121182552.2152891-1-sdf@google.com/
- v1:
https://lore.kernel.org/bpf/20221115030210.3159213-1-sdf@google.com/
- kfuncs v2 RFC:
https://lore.kernel.org/bpf/20221027200019.4106375-1-sdf@google.com/
- kfuncs v1 RFC:
https://lore.kernel.org/bpf/20221104032532.1615099-1-sdf@google.com/
Cc: John Fastabend <john.fastabend@...il.com>
Cc: David Ahern <dsahern@...il.com>
Cc: Martin KaFai Lau <martin.lau@...ux.dev>
Cc: Jakub Kicinski <kuba@...nel.org>
Cc: Willem de Bruijn <willemb@...gle.com>
Cc: Jesper Dangaard Brouer <brouer@...hat.com>
Cc: Anatoly Burakov <anatoly.burakov@...el.com>
Cc: Alexander Lobakin <alexandr.lobakin@...el.com>
Cc: Magnus Karlsson <magnus.karlsson@...il.com>
Cc: Maryam Tahhan <mtahhan@...hat.com>
Cc: xdp-hints@...-project.net
Cc: netdev@...r.kernel.org
Stanislav Fomichev (13):
bpf: Document XDP RX metadata
bpf: Rename bpf_{prog,map}_is_dev_bound to is_offloaded
bpf: Move offload initialization into late_initcall
bpf: Reshuffle some parts of bpf/offload.c
bpf: Introduce device-bound XDP programs
selftests/bpf: Update expected test_offload.py messages
bpf: XDP metadata RX kfuncs
veth: Introduce veth_xdp_buff wrapper for xdp_buff
veth: Support RX XDP metadata
selftests/bpf: Verify xdp_metadata xdp->af_xdp path
net/mlx4_en: Introduce wrapper for xdp_buff
net/mlx4_en: Support RX XDP metadata
selftests/bpf: Simple program to dump XDP RX metadata
Toke Høiland-Jørgensen (4):
bpf: Support consuming XDP HW metadata from fext programs
xsk: Add cb area to struct xdp_buff_xsk
net/mlx5e: Introduce wrapper for xdp_buff
net/mlx5e: Support RX XDP metadata
Documentation/networking/index.rst | 1 +
Documentation/networking/xdp-rx-metadata.rst | 108 +++++
drivers/net/ethernet/mellanox/mlx4/en_clock.c | 13 +-
.../net/ethernet/mellanox/mlx4/en_netdev.c | 6 +
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 63 ++-
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 5 +
drivers/net/ethernet/mellanox/mlx5/core/en.h | 11 +-
.../net/ethernet/mellanox/mlx5/core/en/xdp.c | 26 +-
.../net/ethernet/mellanox/mlx5/core/en/xdp.h | 11 +-
.../ethernet/mellanox/mlx5/core/en/xsk/rx.c | 35 +-
.../ethernet/mellanox/mlx5/core/en/xsk/rx.h | 2 +
.../net/ethernet/mellanox/mlx5/core/en_main.c | 6 +
.../net/ethernet/mellanox/mlx5/core/en_rx.c | 99 ++--
drivers/net/netdevsim/bpf.c | 4 -
drivers/net/veth.c | 87 +++-
include/linux/bpf.h | 61 ++-
include/linux/netdevice.h | 8 +
include/net/xdp.h | 21 +
include/net/xsk_buff_pool.h | 5 +
include/uapi/linux/bpf.h | 5 +
kernel/bpf/core.c | 12 +-
kernel/bpf/offload.c | 426 ++++++++++++------
kernel/bpf/syscall.c | 40 +-
kernel/bpf/verifier.c | 38 +-
net/bpf/test_run.c | 3 +
net/core/dev.c | 9 +-
net/core/filter.c | 2 +-
net/core/xdp.c | 64 +++
tools/include/uapi/linux/bpf.h | 5 +
tools/testing/selftests/bpf/.gitignore | 1 +
tools/testing/selftests/bpf/Makefile | 9 +-
.../selftests/bpf/prog_tests/xdp_metadata.c | 410 +++++++++++++++++
.../selftests/bpf/progs/xdp_hw_metadata.c | 81 ++++
.../selftests/bpf/progs/xdp_metadata.c | 64 +++
.../selftests/bpf/progs/xdp_metadata2.c | 23 +
tools/testing/selftests/bpf/test_offload.py | 10 +-
tools/testing/selftests/bpf/xdp_hw_metadata.c | 405 +++++++++++++++++
tools/testing/selftests/bpf/xdp_metadata.h | 15 +
38 files changed, 1902 insertions(+), 292 deletions(-)
create mode 100644 Documentation/networking/xdp-rx-metadata.rst
create mode 100644 tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
create mode 100644 tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
create mode 100644 tools/testing/selftests/bpf/progs/xdp_metadata.c
create mode 100644 tools/testing/selftests/bpf/progs/xdp_metadata2.c
create mode 100644 tools/testing/selftests/bpf/xdp_hw_metadata.c
create mode 100644 tools/testing/selftests/bpf/xdp_metadata.h
--
2.39.0.314.g84b9a713c41-goog
Powered by blists - more mailing lists