netdev - Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7TJhHjPDQj4UCii@lunn.ch>
Date:   Wed, 4 Jan 2023 01:34:12 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, Jamie Gloudon <jamie.gloudon@....fr>,
        netdev@...r.kernel.org, sasha.neftin@...el.com,
        Naama Meir <naamax.meir@...ux.intel.com>
Subject: Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised
 Support

> @@ -192,10 +194,16 @@ static int e1000_get_link_ksettings(struct net_device *netdev,
>  	if (hw->phy.media_type != e1000_media_type_copper)
>  		cmd->base.eth_tp_mdix_ctrl = ETH_TP_MDI_INVALID;
>  
> +	lpa_t = mii_stat1000_to_ethtool_lpa_t(adapter->phy_regs.stat1000);
> +	lp_advertising = lpa_t |
> +	mii_lpa_to_ethtool_lpa_t(adapter->phy_regs.lpa);

The indentation here is a bit odd.

I would also suggest you split this patch into two, since you are
making two changes, adding pause, and adding LPA.

       Andrew