netdev - Re: [PATCH] 9p/rdma: unmap receive dma buffer in rdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d245e68f-7105-6c12-b732-90d9fef8fb77@huawei.com>
Date:   Wed, 4 Jan 2023 09:30:33 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     <v9fs-developer@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
        <ericvh@...il.com>, <lucho@...kov.net>, <asmadeus@...ewreck.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <linux_oss@...debyte.com>,
        <tom@...ngridcomputing.com>, <weiyongjun1@...wei.com>,
        <yuehaibing@...wei.com>
Subject: Re: [PATCH] 9p/rdma: unmap receive dma buffer in rdma_request()



On 2022/12/28 17:35, Leon Romanovsky wrote:
> On Tue, Dec 20, 2022 at 11:12:23AM +0800, Zhengchao Shao wrote:
>> When down_interruptible() failed in rdma_request(), receive dma buffer
>> is not unmapped. Add unmap action to error path.
>>
>> Fixes: fc79d4b104f0 ("9p: rdma: RDMA Transport Support for 9P")
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> ---
>>   net/9p/trans_rdma.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
>> index 83f9100d46bf..da83023fecbf 100644
>> --- a/net/9p/trans_rdma.c
>> +++ b/net/9p/trans_rdma.c
>> @@ -499,6 +499,8 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req)
>>   
>>   	if (down_interruptible(&rdma->sq_sem)) {
>>   		err = -EINTR;
>> +		ib_dma_unmap_single(rdma->cm_id->device, c->busa,
>> +				    c->req->tc.size, DMA_TO_DEVICE);
>>   		goto send_error;
>>   	}
> 
> It is not the only place where ib_dma_unmap_single() wasn't called.
> Even at the same function if ib_post_send() fails, the unmap is not
> called. Also post_recv() is missing call to ib_dma_unmap_single() too.
> 
> Thanks
> 
Hi Leon：
	Thank you for your review. I'm sorry I haven't answered your
message for so long, I've got Coronavirus and it's a terrible feeling.
I will send v2 soon.

Zhengchao Shao
>>   
>> -- 
>> 2.34.1
>>