netdev - Re: [PATCH 3/3] net: thunderbolt: Add tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7aREZD2r4/PH2lA@black.fi.intel.com>
Date:   Thu, 5 Jan 2023 10:57:53 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] net: thunderbolt: Add tracepoints

Hi,

On Wed, Jan 04, 2023 at 08:50:17PM -0800, Jakub Kicinski wrote:
> On Wed,  4 Jan 2023 10:17:31 +0200 Mika Westerberg wrote:
> > +DECLARE_EVENT_CLASS(tbnet_ip_frame,
> > +	TP_PROTO(u32 size, u32 id, u32 index, u32 count),
> > +	TP_ARGS(size, id, index, count),
> > +	TP_STRUCT__entry(
> > +		__field(u32, size)
> > +		__field(u32, id)
> > +		__field(u32, index)
> > +		__field(u32, count)
> > +	),
> > +	TP_fast_assign(
> > +		__entry->size = le32_to_cpu(size);
> > +		__entry->id = le32_to_cpu(id);
> > +		__entry->index = le32_to_cpu(index);
> > +		__entry->count = le32_to_cpu(count);
> 
> Looks like sparse is not happy with the byte swaps, perhaps PROTO
> can also use the __le32 type?
> 
> Could you make sure there are no new warnings when building with
> 
>   make drivers/net/thunderbolt/ C=1 W=1
> 
> ?

Sure, I will fix then in v2.