netdev - Re: [PATCH net-next v2 10/15] devlink: restart dump based on devlink instance ids (simple)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7aW02IvlYkoIS30@nanopsycho>
Date:   Thu, 5 Jan 2023 10:22:27 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, jacob.e.keller@...el.com
Subject: Re: [PATCH net-next v2 10/15] devlink: restart dump based on devlink
 instance ids (simple)

Thu, Jan 05, 2023 at 05:05:26AM CET, kuba@...nel.org wrote:
>xarray gives each devlink instance an id and allows us to restart
>walk based on that id quite neatly. This is nice both from the
>perspective of code brevity and from the stability of the dump
>(devlink instances disappearing from before the resumption point
>will not cause inconsistent dumps).
>
>This patch takes care of simple cases where state->idx counts
>devlink instances only.
>
>Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

[...]


>+#define devlink_dump_for_each_instance_get(msg, state, devlink)		\
>+	for (; (devlink = devlinks_xa_find_get(sock_net(msg->sk),	\
>+					       &state->instance, xa_find)); \
>+	     state->instance++)

I'm still not happy about this to be honest, but I don't think it
matters now as it is cosmetical. I can try to address it in the
follow-up patch/set.

Reviewed-by: Jiri Pirko <jiri@...dia.com>