netdev - Re: [PATCH net-next 1/5] net/ethtool: add netlink interface for the PLCA RS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jan 2023 13:01:18 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Piergiorgio Beruto <piergiorgio.beruto@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, Oleksij Rempel <o.rempel@...gutronix.de>
Subject: Re: [PATCH net-next 1/5] net/ethtool: add netlink interface for the
 PLCA RS

On Thu, Jan 05, 2023 at 11:47:20AM +0100, Piergiorgio Beruto wrote:
> Thanks Leon for your review.
> Please, see my comments below.

<...>

> > > +	ret = ethnl_ops_begin(dev);
> > > +	if (ret < 0)
> > > +		goto out;
> > 
> > I see that many places in the code used this ret > 0 check, but it looks
> > like the right check is if (ret).
> Thanks. I've fixed those, although I copied this code from similar files
> (like cable test). Maybe we should check these out as well?

I don't think that it is worth to invest time in that. The code works
the same with if (ret<0) and if(!ret).

Thanks

> > 
> > Thanks
> 
> Thanks!
> Piergiorgio