netdev - Re: [PATCH] s390/qeth: convert sysfs snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <645e311c-9aca-b42d-c13c-b4365635e4c2@linux.ibm.com>
Date:   Thu, 5 Jan 2023 13:17:26 +0100
From:   Alexandra Winter <wintera@...ux.ibm.com>
To:     Simon Horman <simon.horman@...igine.com>,
        patchwork-bot+netdevbpf@...nel.org
Cc:     Xuezhi Zhang <zhangxuezhi3@...il.com>, zhangxuezhi1@...lpad.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/qeth: convert sysfs snprintf to sysfs_emit



On 05.01.23 13:02, Simon Horman wrote:
> On Wed, Dec 28, 2022 at 12:20:15PM +0000, patchwork-bot+netdevbpf@...nel.org wrote:
>> Hello:
>>
>> This patch was applied to netdev/net.git (master)
>> by David S. Miller <davem@...emloft.net>:
>>
>> On Tue, 27 Dec 2022 19:03:52 +0800 you wrote:
>>> From: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
>>>
>>> Follow the advice of the Documentation/filesystems/sysfs.rst
>>> and show() should only use sysfs_emit() or sysfs_emit_at()
>>> when formatting the value to be returned to user space.
>>>
>>> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
>>>
>>> [...]
>>
>> Here is the summary with links:
>>   - s390/qeth: convert sysfs snprintf to sysfs_emit
>>     https://git.kernel.org/netdev/net/c/c2052189f19b
> 
> I'm a little late to the party here, but should the use of sprintf() in
> show functions elsewhere in the qeth_core_sys.c also be updated?
> 

Yes, we are working on this. Several patches will come soon, that cleanup whole files.
No need to send additional small patches on this topic at the moment.