netdev - Re: [PATCH] wifi: rt2x00: Remove useless else if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Jan 2023 14:57:26 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     stf_xl@...pl, helmut.schaa@...glemail.com, kvalo@...nel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] wifi: rt2x00: Remove useless else if

Thu, Jan 05, 2023 at 09:58:02AM CET, jiapeng.chong@...ux.alibaba.com wrote:
>The assignment of the else and else if branches is the same, so the else
>if here is redundant, so we remove it and add a comment to make the code
>here readable.
>
>./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8927:9-11: WARNING: possible condition with no effect (if == else).
>
>Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3631
>Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
>---
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
>index 12b700c7b9c3..36b9cd4dd138 100644
>--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
>+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
>@@ -8924,9 +8924,7 @@ static void rt2800_rxiq_calibration(struct rt2x00_dev *rt2x00dev)
> 
> 				if (i < 2 && (bbptemp & 0x800000))
> 					result = (bbptemp & 0xffffff) - 0x1000000;
>-				else if (i == 4)
>-					result = bbptemp;
>-				else
>+				else /* This branch contains if(i==4) */

I don't see how this comment is useful. Better to remove. One way or
another:
Reviewed-by: Jiri Pirko <jiri@...dia.com>



> 					result = bbptemp;
> 
> 				if (i == 0)
>-- 
>2.20.1.7.g153144c
>