netdev - Re: [PATCH net v2 1/3] ice: Prevent set_channel from changing queues while RDMA active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230104204224.31e3eca9@kernel.org>
Date:   Wed, 4 Jan 2023 20:42:24 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        Dave Ertman <david.m.ertman@...el.com>, netdev@...r.kernel.org,
        shiraz.saleem@...el.com, mustafa.ismail@...el.com, jgg@...dia.com,
        leonro@...dia.com, linux-rdma@...r.kernel.org,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net v2 1/3] ice: Prevent set_channel from changing
 queues while RDMA active

On Tue,  3 Jan 2023 15:07:36 -0800 Tony Nguyen wrote:
> +	mutex_lock(&pf->adev_mutex);
> +	if (pf->adev && pf->adev->dev.driver) {
> +		netdev_err(dev, "Cannot change channels when RDMA is active\n");
> +		ret = -EINVAL;
> +		goto adev_unlock;

Since you're have to respin anyway - perhaps -EBUSY here?