netdev - Re: [PATCH v2 00/24] Split netmem from struct page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153c38bf-f16b-cd6f-0c6a-8db226769159@intel.com>
Date:   Thu, 5 Jan 2023 17:20:58 -0800
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>
CC:     <netdev@...r.kernel.org>, <linux-mm@...ck.org>,
        Shakeel Butt <shakeelb@...gle.com>
Subject: Re: [PATCH v2 00/24] Split netmem from struct page

On 1/5/2023 1:46 PM, Matthew Wilcox (Oracle) wrote:
> The MM subsystem is trying to reduce struct page to a single pointer.
> The first step towards that is splitting struct page by its individual
> users, as has already been done with folio and slab.  This patchset does
> that for netmem which is used for page pools.
> 
> There are some relatively significant reductions in kernel text size
> from these changes.  They don't appear to affect performance at all,
> but it's nice to save a bit of memory.
> 
> v2:
>   - Rebase to next-20230105
>   - Add kernel-doc for struct netmem
>   - Add mlx5 compilation fixes from Jesper
>   - Folded in minor nit from Alex Duyck

I had a brief look over the whole series and didn't see anything bad 
that stood out to me.

The series is remarkably small, with many small and easy to review 
patches, so thanks for taking the time to do those.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>