netdev - Re: [PATCH v2] brcmfmac: Prefer DT board type over DMI board type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cf5c1cd-1cc3-35bb-db65-e7f4a3f00527@marcan.st>
Date:   Sat, 7 Jan 2023 01:35:31 +0900
From:   Hector Martin <marcan@...can.st>
To:     Arend Van Spriel <aspriel@...il.com>,
        "Ivan T. Ivanov" <iivanov@...e.de>
Cc:     franky.lin@...adcom.com, hante.meuleman@...adcom.com,
        rmk+kernel@...linux.org.uk, stefan.wahren@...e.com,
        pbrobinson@...il.com, jforbes@...oraproject.org, kvalo@...nel.org,
        davem@...emloft.net, devicetree@...r.kernel.org,
        edumazet@...gle.com, krzysztof.kozlowski+dt@...aro.org,
        kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, stable@...r.kernel.org
Subject: Re: [PATCH v2] brcmfmac: Prefer DT board type over DMI board type

On 07/01/2023 01.21, Arend Van Spriel wrote:
> On 1/6/2023 2:19 PM, Ivan T. Ivanov wrote:
>> The introduction of support for Apple board types inadvertently changed
>> the precedence order, causing hybrid SMBIOS+DT platforms to look up the
>> firmware using the DMI information instead of the device tree compatible
>> to generate the board type. Revert back to the old behavior,
>> as affected platforms use firmwares named after the DT compatible.
>>
>> Fixes: 7682de8b3351 ("wifi: brcmfmac: of: Fetch Apple properties")
>>
>> [1] https://bugzilla.opensuse.org/show_bug.cgi?id=1206697#c13
>>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Ivan T. Ivanov <iivanov@...e.de>
> 
> Looks good to me. I do have a question about the devicetree node for 
> brcmfmac. The driver does a compatible check against 
> "brcm,bcm4329-fmac". I actually expect all devicetree specifications to 
> use this. That said I noticed the check for it in brcmf_of_probe() 
> should be moved so it is the first check done.

We're talking about the machine compatible in the root OF node, not the
compatible for the device itself. That's how firmware selection for
non-Apple platforms works (and has worked since before the Apple stuff
got introduced): first try the machine type which is either derived from
DMI info or the root compatible, and fall back to generic firmware.

The device compatible is indeed always brcm,bcm4329-fmac.

- Hector