netdev - Re: [patch net-next 7/8] devlink: convert reporters dump to devlink_nl_instance_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7lFQa6kBN2AQqz3@nanopsycho>
Date:   Sat, 7 Jan 2023 11:11:13 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, michael.chan@...adcom.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        tariqt@...dia.com, saeedm@...dia.com, leon@...nel.org,
        idosch@...dia.com, petrm@...dia.com, mailhol.vincent@...adoo.fr,
        jacob.e.keller@...el.com, maximmi@...dia.com, gal@...dia.com
Subject: Re: [patch net-next 7/8] devlink: convert reporters dump to
 devlink_nl_instance_iter_dump()

Sat, Jan 07, 2023 at 10:49:08AM CET, jiri@...nulli.us wrote:
>From: Jiri Pirko <jiri@...dia.com>
>
>Benefit from recently introduced instance iteration and convert
>reporters .dumpit generic netlink callback to use it.
>
>Signed-off-by: Jiri Pirko <jiri@...dia.com>
>---
> net/devlink/devl_internal.h | 12 +----
> net/devlink/leftover.c      | 87 ++++++++++++++++---------------------
> net/devlink/netlink.c       |  6 ++-
> 3 files changed, 44 insertions(+), 61 deletions(-)
>
>diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h
>index 52d958c1c977..2b0e119e7b84 100644
>--- a/net/devlink/devl_internal.h
>+++ b/net/devlink/devl_internal.h
>@@ -121,17 +121,6 @@ struct devlink_gen_cmd {
> 			struct netlink_callback *cb);
> };
> 
>-/* Iterate over registered devlink instances for devlink dump.
>- * devlink_put() needs to be called for each iterated devlink pointer
>- * in loop body in order to release the reference.
>- * Note: this is NOT a generic iterator, it makes assumptions about the use
>- *	 of @state and can only be used once per dumpit implementation.
>- */
>-#define devlink_dump_for_each_instance_get(msg, state, devlink)		\
>-	for (; (devlink = devlinks_xa_find_get(sock_net(msg->sk),	\
>-					       &state->instance));	\
>-	     state->instance++, state->idx = 0)
>-

I'm sorry, I managed to quash this during rebase by mistake. Sending v2.