netdev - Re: [PATCH net] ipv6: prevent only DAD and RS sending for IFF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ab910df-c864-7f11-0c1a-acb863dd1539@kernel.org>
Date:   Sat, 7 Jan 2023 19:04:35 -0700
From:   David Ahern <dsahern@...nel.org>
To:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>
Cc:     davem@...emloft.net, kuba@...nel.org,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...nulli.us>,
        LiLiang <liali@...hat.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        jianghaoran <jianghaoran@...inos.cn>,
        Jay Vosburgh <fubar@...ibm.com>
Subject: Re: [PATCH net] ipv6: prevent only DAD and RS sending for
 IFF_NO_ADDRCONF

On 1/6/23 9:51 AM, Xin Long wrote:
> Currently IFF_NO_ADDRCONF is used to prevent all ipv6 addrconf for the
> slave ports of team, bonding and failover devices and it means no ipv6
> packets can be sent out through these slave ports. However, for team
> device, "nsna_ping" link_watch requires ipv6 addrconf. Otherwise, the
> link will be marked failure.
> 
> The orginal issue fixed by IFF_NO_ADDRCONF was caused by DAD and RS
> packets sent by slave ports in commit c2edacf80e15 ("bonding / ipv6: no
> addrconf for slaves separately from master") where it's using IFF_SLAVE
> and later changed to IFF_NO_ADDRCONF in commit 8a321cf7becc ("net: add
> IFF_NO_ADDRCONF and use it in bonding to prevent ipv6 addrconf").

That patch is less than a month old, and you are making changes again.

I think you should add some test cases that cover the permutations you
want along with any possible alternative / negative use cases.