netdev - Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7wQUborYFZ3brPh@lunn.ch>
Date:   Mon, 9 Jan 2023 14:02:09 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     "Neftin, Sasha" <sasha.neftin@...el.com>
Cc:     Jamie Gloudon <jamie.gloudon@....fr>,
        Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
        netdev@...r.kernel.org, Naama Meir <naamax.meir@...ux.intel.com>,
        "Ruinskiy, Dima" <dima.ruinskiy@...el.com>
Subject: Re: [PATCH net-next 1/1] e1000e: Enable Link Partner Advertised
 Support

On Mon, Jan 09, 2023 at 10:40:47AM +0200, Neftin, Sasha wrote:
> On 1/4/2023 19:44, Andrew Lunn wrote:
> > > > I don't know this driver at all. What i don't see anywhere here is
> > > > using the results of the pause auto-neg. Is there some code somewhere
> > > > that looks at the local and link peer advertising values and runs a
> > > > resolve algorithm to determine what pause should be used, and program
> > > > it into the MAC?
> > > > 
> > > >      Andrew
> > > This is a old patch i had laying around, If i remember correctly, phy->autoneg_advertised plugs in "Link partner
> > > advertised pause frame use link" line in ethtool everytime the nic renegotiate.
> > 
> > Hi Jamie
> > 
> > Could you point me at the code which interprets the results of the
> > auto neg and configures the MAC for the correct pause.
> probably you look at  e1000e_config_fc_after_link_up method
> (this is very legacy code https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/intel/e1000e/mac.c#L1001)

Thanks. That is exactly what i wanted to see.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew