netdev - Re: [PATCHv3 net-next] sched: multicast sched extack messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2023 10:57:40 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCHv3 net-next] sched: multicast sched extack messages

On Mon, Jan 9, 2023 at 10:56 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
IMO the feature is useful. The idea of using a single tool to get the
details improves the operational experience.
And in this case this is a valid event (someone tried to add an entry
to hardware and s/ware and it worked for
one and not the other).
I think Jakub's objection is in the approach. Jakub, would  using
specific attributes restricted to
just QDISC/FILTER/ACTION work for you?

cheers,
jamal


On Thu, Jan 5, 2023 at 5:12 AM Hangbin Liu <liuhangbin@...il.com> wrote:
On Wed, Jan 04, 2023 at 08:01:13PM -0800, Jakub Kicinski wrote:
> On Wed,  4 Jan 2023 17:16:08 +0800 Hangbin Liu wrote:
> > In commit 81c7288b170a ("sched: cls: enable verbose logging") Marcelo
> > made cls could log verbose info for offloading failures, which helps
> > improving Open vSwitch debuggability when using flower offloading.
> >
> > It would also be helpful if userspace monitor tools, like "tc monitor",
> > could log this kind of message, as it doesn't require vswitchd log level
> > adjusment. Let's add a new function to report the extack message so the
> > monitor program could receive the failures. e.g.
>
> If you repost this ever again please make sure you include my tag:
>
> Nacked-by: Jakub Kicinski <kuba@...nel.org>
>
> I explained to you at least twice why this is a terrible idea,
> and gave you multiple alternatives.

Hi Jakub,

I'm very sorry if this patch makes you feel disturbed. I switched the
notification
to NLMSG_ERROR instead of NLMSG_DONE as you pointed out. I also made the
notification only in sched sub-system, not using netlink_ack() globally.
Oh, and forgot to reply to you, I use portid and seq in the notification as all
the tc notifies also use them.

In the last patch, I saw Jamal reply to you about the usability. So I thought
you might reconsider this feature. Now I will stop posting this patch unless
you agree to keep working on this.

Sorry again if I missed any other suggestions from you.

Best regards
Hangbin

On Thu, Jan 5, 2023 at 5:12 AM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> On Wed, Jan 04, 2023 at 08:01:13PM -0800, Jakub Kicinski wrote:
> > On Wed,  4 Jan 2023 17:16:08 +0800 Hangbin Liu wrote:
> > > In commit 81c7288b170a ("sched: cls: enable verbose logging") Marcelo
> > > made cls could log verbose info for offloading failures, which helps
> > > improving Open vSwitch debuggability when using flower offloading.
> > >
> > > It would also be helpful if userspace monitor tools, like "tc monitor",
> > > could log this kind of message, as it doesn't require vswitchd log level
> > > adjusment. Let's add a new function to report the extack message so the
> > > monitor program could receive the failures. e.g.
> >
> > If you repost this ever again please make sure you include my tag:
> >
> > Nacked-by: Jakub Kicinski <kuba@...nel.org>
> >
> > I explained to you at least twice why this is a terrible idea,
> > and gave you multiple alternatives.
>
> Hi Jakub,
>
> I'm very sorry if this patch makes you feel disturbed. I switched the notification
> to NLMSG_ERROR instead of NLMSG_DONE as you pointed out. I also made the
> notification only in sched sub-system, not using netlink_ack() globally.
> Oh, and forgot to reply to you, I use portid and seq in the notification as all
> the tc notifies also use them.
>
> In the last patch, I saw Jamal reply to you about the usability. So I thought
> you might reconsider this feature. Now I will stop posting this patch unless
> you agree to keep working on this.
>
> Sorry again if I missed any other suggestions from you.
>
> Best regards
> Hangbin