netdev - Re: [PATCH v8 06/25] net/tls,core: export get_netdev_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301100144.ME0aBrEE-lkp@intel.com>
Date:   Tue, 10 Jan 2023 01:49:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     Aurelien Aptel <aaptel@...dia.com>, linux-nvme@...ts.infradead.org,
        netdev@...r.kernel.org, sagi@...mberg.me, hch@....de,
        kbusch@...nel.org, axboe@...com, chaitanyak@...dia.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, Aurelien Aptel <aaptel@...dia.com>,
        aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
        ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com
Subject: Re: [PATCH v8 06/25] net/tls,core: export get_netdev_for_sock

Hi Aurelien,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master linus/master v6.2-rc3 next-20230109]
[cannot apply to hch-configfs/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aurelien-Aptel/net-Introduce-direct-data-placement-tcp-offload/20230109-213850
patch link:    https://lore.kernel.org/r/20230109133116.20801-7-aaptel%40nvidia.com
patch subject: [PATCH v8 06/25] net/tls,core: export get_netdev_for_sock
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7a172487455cb4d34676606dad25db474fbea682
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Aurelien-Aptel/net-Introduce-direct-data-placement-tcp-offload/20230109-213850
        git checkout 7a172487455cb4d34676606dad25db474fbea682
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/core/dev.c:8162: warning: expecting prototype for netdev_sk_get_lowest_dev(). Prototype was for get_netdev_for_sock() instead


vim +8162 net/core/dev.c

719a402cf60311 Tariq Toukan   2021-01-17  8153  
719a402cf60311 Tariq Toukan   2021-01-17  8154  /**
7a172487455cb4 Aurelien Aptel 2023-01-09  8155   * netdev_sk_get_lowest_dev - Get the lowest device in socket
719a402cf60311 Tariq Toukan   2021-01-17  8156   * @sk: the socket
719a402cf60311 Tariq Toukan   2021-01-17  8157   *
7a172487455cb4 Aurelien Aptel 2023-01-09  8158   * Assumes that the socket is already connected.
7a172487455cb4 Aurelien Aptel 2023-01-09  8159   * Returns the lower device or %NULL if no lower device is found.
719a402cf60311 Tariq Toukan   2021-01-17  8160   */
7a172487455cb4 Aurelien Aptel 2023-01-09  8161  struct net_device *get_netdev_for_sock(struct sock *sk)
719a402cf60311 Tariq Toukan   2021-01-17 @8162  {
7a172487455cb4 Aurelien Aptel 2023-01-09  8163  	struct dst_entry *dst = sk_dst_get(sk);
7a172487455cb4 Aurelien Aptel 2023-01-09  8164  	struct net_device *dev, *lower;
719a402cf60311 Tariq Toukan   2021-01-17  8165  
7a172487455cb4 Aurelien Aptel 2023-01-09  8166  	if (unlikely(!dst))
7a172487455cb4 Aurelien Aptel 2023-01-09  8167  		return NULL;
7a172487455cb4 Aurelien Aptel 2023-01-09  8168  	dev = dst->dev;
7a172487455cb4 Aurelien Aptel 2023-01-09  8169  	while ((lower = netdev_sk_get_lower_dev(dev, sk)))
719a402cf60311 Tariq Toukan   2021-01-17  8170  		dev = lower;
7a172487455cb4 Aurelien Aptel 2023-01-09  8171  	dev_hold(dev);
7a172487455cb4 Aurelien Aptel 2023-01-09  8172  	dst_release(dst);
719a402cf60311 Tariq Toukan   2021-01-17  8173  	return dev;
719a402cf60311 Tariq Toukan   2021-01-17  8174  }
7a172487455cb4 Aurelien Aptel 2023-01-09  8175  EXPORT_SYMBOL_GPL(get_netdev_for_sock);
719a402cf60311 Tariq Toukan   2021-01-17  8176  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (278735 bytes)