netdev - RE: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB34954944702CEA4F29A989CCF7FE9@BYAPR11MB3495.namprd11.prod.outlook.com>
Date:   Mon, 9 Jan 2023 23:52:43 +0000
From:   "Wang, Haiyue" <haiyue.wang@...el.com>
To:     "sdf@...gle.com" <sdf@...gle.com>
CC:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, Hao Luo <haoluo@...gle.com>,
        Jiri Olsa <jolsa@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer
 comparison

> -----Original Message-----
> From: sdf@...gle.com <sdf@...gle.com>
> Sent: Tuesday, January 10, 2023 01:39
> To: Wang, Haiyue <haiyue.wang@...el.com>
> Cc: bpf@...r.kernel.org; Alexei Starovoitov <ast@...nel.org>; Daniel Borkmann <daniel@...earbox.net>;
> Andrii Nakryiko <andrii@...nel.org>; Martin KaFai Lau <martin.lau@...ux.dev>; Song Liu
> <song@...nel.org>; Yonghong Song <yhs@...com>; John Fastabend <john.fastabend@...il.com>; KP Singh
> <kpsingh@...nel.org>; Hao Luo <haoluo@...gle.com>; Jiri Olsa <jolsa@...nel.org>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer comparison
> 
> On 01/08, Haiyue Wang wrote:
> > The variable 'insn' is initialized to 'insn_buf' without being changed,
> > only some helper macros are defined, so the insn buffer comparison is
> > unnecessary, just remove it.
> 
> > Signed-off-by: Haiyue Wang <haiyue.wang@...el.com>
> 
> Acked-by: Stanislav Fomichev <sdf@...gle.com>
> 
> Looks like these should have been removed as part of commit 2377b81de527
> ("bpf: split shared bpf_tcp_sock and bpf_sock_ops implementation").
> 

Thanks for the information, yes, it was missed. ;-)

> > ---
> >   net/core/filter.c | 6 ------
> >   1 file changed, 6 deletions(-)
> 


> > --
> > 2.39.0