netdev - Re: [PATCH net-next] net: ethernet: mtk_wed: get rid of queue lock for rx queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y70rlWO+30+y8aOJ@lore-desk>
Date:   Tue, 10 Jan 2023 10:10:45 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Lorenzo Bianconi <lorenzo@...nel.org>,
        Alexander H Duyck <alexander.duyck@...il.com>,
        netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, nbd@....name, john@...ozen.org,
        sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        sujuan.chen@...iatek.com, daniel@...rotopia.org
Subject: Re: [PATCH net-next] net: ethernet: mtk_wed: get rid of queue lock
 for rx queue

> On Mon, 09 Jan 2023 16:50:55 -0800 Alexander H Duyck wrote:
> > On Sat, 2023-01-07 at 15:41 +0100, Lorenzo Bianconi wrote:
> > > mtk_wed_wo_queue_rx_clean and mtk_wed_wo_queue_refill routines can't run
> > > concurrently so get rid of spinlock for rx queues.
> 
> You say "for rx queues" but mtk_wed_wo_queue_refill() is also called
> for tx queues.

ack, but for tx queues is run just during initialization.

> 
> > My understanding is that mtk_wed_wo_queue_refill will only be called
> > during init and by the tasklet. The mtk_wed_wo_queue_rx_clean function
> > is only called during deinit and only after the tasklet has been
> > disabled. That is the reason they cannot run at the same time correct?
> > 
> > It would be nice if you explained why they couldn't run concurrently
> > rather than just stating it is so in the patch description. It makes it
> > easier to verify assumptions that way. Otherwise the patch itself looks
> > good to me.
> 
> Agreed, please respin with a better commit message.
> 

ack, I will post v2 with a better commit message.

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)