lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANn89iL0EYuGASWaXPwKN+E6mZvFicbDKOoZVA8N+BXFQV7e2A@mail.gmail.com> Date: Tue, 10 Jan 2023 10:29:20 +0100 From: Eric Dumazet <edumazet@...gle.com> To: 李哲 <sensor1010@....com>, Wei Wang <weiwan@...gle.com> Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, bigeasy@...utronix.de, imagedong@...cent.com, kuniyu@...zon.com, petrm@...dia.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v1] net/dev.c : Remove redundant state settings after waking up On Tue, Jan 10, 2023 at 10:15 AM 李哲 <sensor1010@....com> wrote: > > the task status has been set to TASK_RUNNING in shcedule(), > no need to set again here Changelog is rather confusing, this does not match the patch, which removes one set_current_state(TASK_INTERRUPTIBLE); TASK_INTERRUPTIBLE != TASK_RUNNING Patch itself looks okay (but has nothing to do with thread state after schedule()), you should have CC Wei Wang because she authored commit cb038357937e net: fix race between napi kthread mode and busy poll > > Signed-off-by: 李哲 <sensor1010@....com> > --- > net/core/dev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index b76fb37b381e..4bd2d4b954c9 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -6580,7 +6580,6 @@ static int napi_thread_wait(struct napi_struct *napi) > schedule(); > /* woken being true indicates this thread owns this napi. */ > woken = true; > - set_current_state(TASK_INTERRUPTIBLE); > } > __set_current_state(TASK_RUNNING); > > -- > 2.17.1 >
Powered by blists - more mailing lists