netdev - Re: [PATCHv3 net-next] sched: multicast sched extack messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y707Pa+U7LiJBER/@Laptop-X1>
Date:   Tue, 10 Jan 2023 18:17:33 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, netdev@...r.kernel.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCHv3 net-next] sched: multicast sched extack messages

On Mon, Jan 09, 2023 at 11:43:06AM -0800, Jakub Kicinski wrote:
> On Mon, 9 Jan 2023 10:56:00 -0500 Jamal Hadi Salim wrote:
> > IMO the feature is useful. The idea of using a single tool to get the
> > details improves the operational experience.
> > And in this case this is a valid event (someone tried to add an entry to
> > hardware and s/ware and it worked for
> > one and not the other).
> > I think Jakub's objection is in the approach.
> 
> Right.
> 
> > Jakub, would  using specific attributes restricted to
> > just QDISC/FILTER/ACTION work for you?
> 
> Yes, specific attr to wrap the extack seems acceptable.

Looks we go back to the TCA_NTF_WARN_MSG approach[1], right?

[1] https://lore.kernel.org/all/Y3OJucOnuGrBvwYM@Laptop-X1/

Thanks
Hangbin