lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y71CbrB6/WnxERSF@hera> Date: Tue, 10 Jan 2023 12:48:14 +0200 From: Ilias Apalodimas <ilias.apalodimas@...aro.org> To: "Matthew Wilcox (Oracle)" <willy@...radead.org> Cc: Jesper Dangaard Brouer <hawk@...nel.org>, netdev@...r.kernel.org, linux-mm@...ck.org, Shakeel Butt <shakeelb@...gle.com> Subject: Re: [PATCH v2 14/24] page_pool: Convert page_pool_recycle_in_cache() to netmem On Thu, Jan 05, 2023 at 09:46:21PM +0000, Matthew Wilcox (Oracle) wrote: > Removes a few casts. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org> > --- > net/core/page_pool.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 3fa03baa80ee..b925a4dcb09b 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -538,7 +538,7 @@ static bool page_pool_recycle_in_ring(struct page_pool *pool, > * > * Caller must provide appropriate safe context. > */ > -static bool page_pool_recycle_in_cache(struct page *page, > +static bool page_pool_recycle_in_cache(struct netmem *nmem, > struct page_pool *pool) > { > if (unlikely(pool->alloc.count == PP_ALLOC_CACHE_SIZE)) { > @@ -547,7 +547,7 @@ static bool page_pool_recycle_in_cache(struct page *page, > } > > /* Caller MUST have verified/know (page_ref_count(page) == 1) */ > - pool->alloc.cache[pool->alloc.count++] = page_netmem(page); > + pool->alloc.cache[pool->alloc.count++] = nmem; > recycle_stat_inc(pool, cached); > return true; > } > @@ -580,7 +580,7 @@ __page_pool_put_netmem(struct page_pool *pool, struct netmem *nmem, > dma_sync_size); > > if (allow_direct && in_serving_softirq() && > - page_pool_recycle_in_cache(netmem_page(nmem), pool)) > + page_pool_recycle_in_cache(nmem, pool)) > return NULL; > > /* Page found as candidate for recycling */ > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
Powered by blists - more mailing lists