netdev - [PATCH v2] net/core.c : remove redundant state settings after waking up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230110111413.3747-1-sensor1010@163.com>
Date:   Tue, 10 Jan 2023 03:14:13 -0800
From:   Lizhe <sensor1010@....com>
To:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, bigeasy@...utronix.de, imagedong@...cent.com,
        kuniyu@...zon.com, petrm@...dia.com, weiwan@...gle.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lizhe <sensor1010@....com>
Subject: [PATCH v2] net/core.c : remove redundant state settings after waking up

when schedule() returns, the current state is TASK_RUNNING, no
need to set its status to TASK_INTERRUPTIBLE, and after jumping
out of the wile loop, its status will be set to TASK_RUNNING,
so, set_current_state(TASK_INTERRUPTIBLE) is redundant

Signed-off-by: Lizhe <sensor1010@....com>
---
 net/core/dev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index b76fb37b381e..4bd2d4b954c9 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6580,7 +6580,6 @@ static int napi_thread_wait(struct napi_struct *napi)
 		schedule();
 		/* woken being true indicates this thread owns this napi. */
 		woken = true;
-		set_current_state(TASK_INTERRUPTIBLE);
 	}
 	__set_current_state(TASK_RUNNING);
 
-- 
2.17.1