lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <2037156d-5113-4b96-8f86-c8ef1c1fdf96@linaro.org> Date: Tue, 10 Jan 2023 15:17:34 +0100 From: Neil Armstrong <neil.armstrong@...aro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>, Mauro Carvalho Chehab <mchehab@...nel.org>, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk> Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org, linux-media@...r.kernel.org, linux-rtc@...r.kernel.org, linux-phy@...ts.infradead.org, linux-mmc@...r.kernel.org, linux-pci@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2 09/11] dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema On 10/01/2023 11:17, Krzysztof Kozlowski wrote: > On 09/01/2023 13:53, Neil Armstrong wrote: >> Convert the Amlogic SD / eMMC controller for S905/GXBB family SoCs >> to dt-schema. >> >> Take in account the used variant with amlogic,meson-gx-mmc. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org> >> --- >> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 75 ++++++++++++++++++++++ >> .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 ----------- >> 2 files changed, 75 insertions(+), 39 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >> new file mode 100644 >> index 000000000000..30228964fd9c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >> @@ -0,0 +1,75 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mmc/amlogic,meson-gx-mmc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic SD / eMMC controller for S905/GXBB family SoCs >> + >> +description: >> + The MMC 5.1 compliant host controller on Amlogic provides the >> + interface for SD, eMMC and SDIO devices >> + >> +maintainers: >> + - Neil Armstrong <neil.armstrong@...aro.org> >> + >> +allOf: >> + - $ref: mmc-controller.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - enum: >> + - amlogic,meson-gx-mmc >> + - amlogic,meson-axg-mmc >> + - items: >> + - const: amlogic,meson-gx-mmc > > This does not look correct. Either gx is alone (not compatible with > gxbb) or it is compatible with gxbb. Cannot be both. This ishow it's used in DT: arch/arm64/boot/dts/amlogic/meson-gx.dtsi: compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; arch/arm64/boot/dts/amlogic/meson-axg.dtsi: compatible = "amlogic,meson-axg-mmc"; arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi: compatible = "amlogic,meson-axg-mmc"; So I'll drop the amlogic,meson-gx-mmc in the first enum to have : +properties: + compatible: + oneOf: + - const: amlogic,meson-axg-mmc + - items: + - const: amlogic,meson-gx-mmc + - const: amlogic,meson-gxbb-mmc It's right ? Neil > > > > Best regards, > Krzysztof >
Powered by blists - more mailing lists