netdev - Re: [PATCH net-next v1 1/7] net: flow_offload: provision conntrack info in ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202301102313.Lok19lDJ-lkp@intel.com>
Date:   Tue, 10 Jan 2023 23:14:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vlad Buslov <vladbu@...dia.com>, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, pablo@...filter.org
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, ozsh@...dia.com,
        marcelo.leitner@...il.com, simon.horman@...igine.com,
        Vlad Buslov <vladbu@...dia.com>
Subject: Re: [PATCH net-next v1 1/7] net: flow_offload: provision conntrack
 info in ct_metadata

Hi Vlad,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Vlad-Buslov/net-flow_offload-provision-conntrack-info-in-ct_metadata/20230110-213500
patch link:    https://lore.kernel.org/r/20230110133023.2366381-2-vladbu%40nvidia.com
patch subject: [PATCH net-next v1 1/7] net: flow_offload: provision conntrack info in ct_metadata
config: i386-tinyconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/99f16b3535be4a9588707780f082146c647c5b5f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vlad-Buslov/net-flow_offload-provision-conntrack-info-in-ct_metadata/20230110-213500
        git checkout 99f16b3535be4a9588707780f082146c647c5b5f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/net/sch_generic.h:21,
                    from include/linux/filter.h:26,
                    from kernel/sysctl.c:35:
>> include/net/flow_offload.h:291:48: error: field 'ctinfo' has incomplete type
     291 |                         enum ip_conntrack_info ctinfo;
         |                                                ^~~~~~


vim +/ctinfo +291 include/net/flow_offload.h

   227	
   228	struct flow_action_entry {
   229		enum flow_action_id		id;
   230		u32				hw_index;
   231		enum flow_action_hw_stats	hw_stats;
   232		action_destr			destructor;
   233		void				*destructor_priv;
   234		union {
   235			u32			chain_index;	/* FLOW_ACTION_GOTO */
   236			struct net_device	*dev;		/* FLOW_ACTION_REDIRECT */
   237			struct {				/* FLOW_ACTION_VLAN */
   238				u16		vid;
   239				__be16		proto;
   240				u8		prio;
   241			} vlan;
   242			struct {				/* FLOW_ACTION_VLAN_PUSH_ETH */
   243				unsigned char dst[ETH_ALEN];
   244				unsigned char src[ETH_ALEN];
   245			} vlan_push_eth;
   246			struct {				/* FLOW_ACTION_MANGLE */
   247								/* FLOW_ACTION_ADD */
   248				enum flow_action_mangle_base htype;
   249				u32		offset;
   250				u32		mask;
   251				u32		val;
   252			} mangle;
   253			struct ip_tunnel_info	*tunnel;	/* FLOW_ACTION_TUNNEL_ENCAP */
   254			u32			csum_flags;	/* FLOW_ACTION_CSUM */
   255			u32			mark;		/* FLOW_ACTION_MARK */
   256			u16                     ptype;          /* FLOW_ACTION_PTYPE */
   257			u16			rx_queue;	/* FLOW_ACTION_RX_QUEUE_MAPPING */
   258			u32			priority;	/* FLOW_ACTION_PRIORITY */
   259			struct {				/* FLOW_ACTION_QUEUE */
   260				u32		ctx;
   261				u32		index;
   262				u8		vf;
   263			} queue;
   264			struct {				/* FLOW_ACTION_SAMPLE */
   265				struct psample_group	*psample_group;
   266				u32			rate;
   267				u32			trunc_size;
   268				bool			truncate;
   269			} sample;
   270			struct {				/* FLOW_ACTION_POLICE */
   271				u32			burst;
   272				u64			rate_bytes_ps;
   273				u64			peakrate_bytes_ps;
   274				u32			avrate;
   275				u16			overhead;
   276				u64			burst_pkt;
   277				u64			rate_pkt_ps;
   278				u32			mtu;
   279				struct {
   280					enum flow_action_id	act_id;
   281					u32			extval;
   282				} exceed, notexceed;
   283			} police;
   284			struct {				/* FLOW_ACTION_CT */
   285				int action;
   286				u16 zone;
   287				struct nf_flowtable *flow_table;
   288			} ct;
   289			struct {
   290				unsigned long cookie;
 > 291				enum ip_conntrack_info ctinfo;
   292				u32 mark;
   293				u32 labels[4];
   294				bool orig_dir;
   295			} ct_metadata;
   296			struct {				/* FLOW_ACTION_MPLS_PUSH */
   297				u32		label;
   298				__be16		proto;
   299				u8		tc;
   300				u8		bos;
   301				u8		ttl;
   302			} mpls_push;
   303			struct {				/* FLOW_ACTION_MPLS_POP */
   304				__be16		proto;
   305			} mpls_pop;
   306			struct {				/* FLOW_ACTION_MPLS_MANGLE */
   307				u32		label;
   308				u8		tc;
   309				u8		bos;
   310				u8		ttl;
   311			} mpls_mangle;
   312			struct {
   313				s32		prio;
   314				u64		basetime;
   315				u64		cycletime;
   316				u64		cycletimeext;
   317				u32		num_entries;
   318				struct action_gate_entry *entries;
   319			} gate;
   320			struct {				/* FLOW_ACTION_PPPOE_PUSH */
   321				u16		sid;
   322			} pppoe;
   323		};
   324		struct flow_action_cookie *cookie; /* user defined action cookie */
   325	};
   326	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (29882 bytes)