netdev - Re: [PATCH net-next 2/7] PCI: Remove PCI IDs used by the Sun Cassini driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230110152606.GA1504608@bhelgaas>
Date:   Tue, 10 Jan 2023 09:26:06 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
Cc:     netdev@...r.kernel.org, linux-pci@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-mips@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
        Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH net-next 2/7] PCI: Remove PCI IDs used by the Sun Cassini
 driver

On Fri, Jan 06, 2023 at 02:00:15PM -0800, Anirudh Venkataramanan wrote:
> The previous patch removed the Cassini driver (drivers/net/ethernet/sun).
> With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are
> unused. Remove them.
> 
> Cc: Leon Romanovsky <leon@...nel.org>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
> ---
>  include/linux/pci_ids.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90..eca2340 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -433,7 +433,6 @@
>  #define PCI_DEVICE_ID_NS_CS5535_AUDIO	0x002e
>  #define PCI_DEVICE_ID_NS_CS5535_USB	0x002f
>  #define PCI_DEVICE_ID_NS_GX_VIDEO	0x0030
> -#define PCI_DEVICE_ID_NS_SATURN		0x0035
>  #define PCI_DEVICE_ID_NS_SCx200_BRIDGE	0x0500
>  #define PCI_DEVICE_ID_NS_SCx200_SMI	0x0501
>  #define PCI_DEVICE_ID_NS_SCx200_IDE	0x0502
> @@ -1047,7 +1046,6 @@
>  #define PCI_DEVICE_ID_SUN_SABRE		0xa000
>  #define PCI_DEVICE_ID_SUN_HUMMINGBIRD	0xa001
>  #define PCI_DEVICE_ID_SUN_TOMATILLO	0xa801
> -#define PCI_DEVICE_ID_SUN_CASSINI	0xabba

I don't think there's value in removing these definitions.  I would
just leave them alone.