netdev - Re: [PATCH net-next 7/9] devlink: allow registering parameters after the instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y72T11cDw7oNwHnQ@nanopsycho>
Date:   Tue, 10 Jan 2023 17:35:35 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
        netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH net-next 7/9] devlink: allow registering parameters after
 the instance

Tue, Jan 10, 2023 at 01:21:18AM CET, jacob.e.keller@...el.com wrote:
>
>
>On 1/6/2023 1:22 PM, Jakub Kicinski wrote:
>> On Fri, 6 Jan 2023 13:55:53 +0100 Jiri Pirko wrote:
>>>> @@ -5263,7 +5263,13 @@ static void devlink_param_notify(struct devlink *devlink,
>>>> 	WARN_ON(cmd != DEVLINK_CMD_PARAM_NEW && cmd != DEVLINK_CMD_PARAM_DEL &&
>>>> 		cmd != DEVLINK_CMD_PORT_PARAM_NEW &&
>>>> 		cmd != DEVLINK_CMD_PORT_PARAM_DEL);
>>>> -	ASSERT_DEVLINK_REGISTERED(devlink);
>>>> +
>>>> +	/* devlink_notify_register() / devlink_notify_unregister()
>>>> +	 * will replay the notifications if the params are added/removed
>>>> +	 * outside of the lifetime of the instance.
>>>> +	 */
>>>> +	if (!devl_is_registered(devlink))
>>>> +		return;  
>>>
>>> This helper would be nice to use on other places as well.
>>> Like devlink_trap_group_notify(), devlink_trap_notify() and others. I
>>> will take care of that in a follow-up.
>> 
>> Alternatively we could reorder back to registering sub-objects
>> after the instance and not have to worry about re-sending 
>> notifications :S
>
>I did find it convenient to be able to do both pre and post-registering,
>but of the two I'd definitely prefer doing it post-registering, as that
>makes it easier to handle/allow more dynamic sub-objects.

I'm confused. You want to register objects after instance register?