netdev - Re: [PATCH] net: ena: initialize dim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y72V/Z3M8C7Un/QV@nanopsycho>
Date:   Tue, 10 Jan 2023 17:44:45 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Tom Rix <trix@...hat.com>
Cc:     shayagr@...zon.com, akiyano@...zon.com, darinzon@...zon.com,
        ndagan@...zon.com, saeedb@...zon.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        nathan@...nel.org, ndesaulniers@...gle.com, khalasa@...p.pl,
        wsa+renesas@...g-engineering.com, yuancan@...wei.com,
        tglx@...utronix.de, 42.hyeyoo@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] net: ena: initialize dim_sample

Sun, Jan 08, 2023 at 03:38:43PM CET, trix@...hat.com wrote:
>clang static analysis reports this problem
>drivers/net/ethernet/amazon/ena/ena_netdev.c:1821:2: warning: Passed-by-value struct
>  argument contains uninitialized data (e.g., field: 'comp_ctr') [core.CallAndMessage]
>        net_dim(&ena_napi->dim, dim_sample);
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>net_dim can call dim_calc_stats() which uses the comp_ctr element,
>so it must be initialized.
>
>Fixes: 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive interrupt moderation")
>Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>