netdev - Re: [PATCH 1/8] bnxt_en: Add auxiliary driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACZ4nhv+wuSRe6ZvMrHfVuZLzPNphzH=ErgC=90aU-9sWeQi3g@mail.gmail.com>
Date:   Tue, 10 Jan 2023 15:49:11 -0800
From:   Ajit Khaparde <ajit.khaparde@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     andrew.gospodarek@...adcom.com, davem@...emloft.net,
        edumazet@...gle.com, jgg@...pe.ca, leon@...nel.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        michael.chan@...adcom.com, netdev@...r.kernel.org,
        pabeni@...hat.com, selvin.xavier@...adcom.com
Subject: Re: [PATCH 1/8] bnxt_en: Add auxiliary driver support

On Tue, Jan 10, 2023 at 2:51 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sat,  7 Jan 2023 19:02:01 -0800 Ajit Khaparde wrote:
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
:::: snip ::::
>
> This forward declaration is not needed, at least in this patch.
>
> >  struct bnxt;
> >
> >  struct bnxt_msix_entry {
> > @@ -102,10 +103,14 @@ int bnxt_get_ulp_stat_ctxs(struct bnxt *bp);
> >  void bnxt_ulp_stop(struct bnxt *bp);
> >  void bnxt_ulp_start(struct bnxt *bp, int err);
> >  void bnxt_ulp_sriov_cfg(struct bnxt *bp, int num_vfs);
> > -void bnxt_ulp_shutdown(struct bnxt *bp);
> >  void bnxt_ulp_irq_stop(struct bnxt *bp);
> >  void bnxt_ulp_irq_restart(struct bnxt *bp, int err);
> >  void bnxt_ulp_async_events(struct bnxt *bp, struct hwrm_async_event_cmpl *cmpl);
> > +void bnxt_aux_dev_release(struct device *dev);
> > +int bnxt_rdma_aux_device_add(struct bnxt *bp);
>
> This is only used in bnxt_ulp.c, please remove the declaration and make
> it static. Please check other functions for the same problem.
>
> > +void bnxt_rdma_aux_device_uninit(struct bnxt *bp);
> > +void bnxt_rdma_aux_device_init(struct bnxt *bp);
> > +void bnxt_aux_dev_free(struct bnxt *bp);
>
Thanks Kuba. I will go over the comments and send the next version.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4218 bytes)