netdev - Re: [patch net-next v3 00/11] devlink: features, linecard and reporters locking cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2023 09:14:39 +0200
From:   Ido Schimmel <idosch@...dia.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, michael.chan@...adcom.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        tariqt@...dia.com, saeedm@...dia.com, leon@...nel.org,
        petrm@...dia.com, mailhol.vincent@...adoo.fr,
        jacob.e.keller@...el.com, gal@...dia.com
Subject: Re: [patch net-next v3 00/11] devlink: features, linecard and
 reporters locking cleanup

On Tue, Jan 10, 2023 at 10:40:42AM +0200, Ido Schimmel wrote:
> On Mon, Jan 09, 2023 at 07:31:09PM +0100, Jiri Pirko wrote:
> > From: Jiri Pirko <jiri@...dia.com>
> > 
> > This patchset does not change functionality.
> > 
> > In the first patch, no longer needed devlink features are removed.
> > 
> > Patches 2-7 removes linecards and reporters locks and reference counting,
> > converting them to be protected by devlink instance lock as the rest of
> > the objects.
> > 
> > Patches 8 and 9 convert linecards and reporters dumpit callbacks to
> > recently introduced devlink_nl_instance_iter_dump() infra.
> > Patch 10 removes no longer needed devlink_dump_for_each_instance_get()
> > helper.
> > 
> > The last patch adds assertion to devl_is_registered() as dependency on
> > other locks is removed.
> 
> Asked Petr to queue this for testing, so we should be able to report
> results tomorrow.

Looks OK, no regressions.