netdev - Re: [PATCH net-next 7/9] devlink: allow registering parameters after the instance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y76CHc18xSlcXdWJ@nanopsycho>
Date:   Wed, 11 Jan 2023 10:32:13 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jacob Keller <jacob.e.keller@...el.com>, davem@...emloft.net,
        netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH net-next 7/9] devlink: allow registering parameters after
 the instance

Tue, Jan 10, 2023 at 09:22:22PM CET, kuba@...nel.org wrote:
>On Tue, 10 Jan 2023 17:35:35 +0100 Jiri Pirko wrote:
>> >I did find it convenient to be able to do both pre and post-registering,
>> >but of the two I'd definitely prefer doing it post-registering, as that
>> >makes it easier to handle/allow more dynamic sub-objects.  
>> 
>> I'm confused. You want to register objects after instance register?
>
>+1, I think it's an anti-pattern.

Could you elaborate a bit please?