netdev - RE: [EXT] Re: [PATCH v1 net-next,8/8] octeontx2-af: add mbox to return CPT_AF_FLT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR18MB27918F023EA91C5925AF80F6A0FC9@BYAPR18MB2791.namprd18.prod.outlook.com>
Date:   Wed, 11 Jan 2023 11:20:35 +0000
From:   Srujana Challa <schalla@...vell.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>
Subject: RE: [EXT] Re: [PATCH v1 net-next,8/8] octeontx2-af: add mbox to
 return CPT_AF_FLT_INT info

> ----------------------------------------------------------------------
> On Tue, Jan 10, 2023 at 11:52:58AM +0530, Srujana Challa wrote:
> > Adds a new mailbox to return CPT faulted engines bitmap and recovered
> > engines bitmap.
> >
> > Signed-off-by: Srujana Challa <schalla@...vell.com>
> > ---
> >  .../net/ethernet/marvell/octeontx2/af/mbox.h  | 17 ++++++++++
> >  .../net/ethernet/marvell/octeontx2/af/rvu.h   |  4 +++
> >  .../ethernet/marvell/octeontx2/af/rvu_cpt.c   | 34
> +++++++++++++++++++
> >  3 files changed, 55 insertions(+)
> 
> <...>
> 
> > +		spin_lock(&rvu->cpt_intr_lock);
> > +		block->cpt_flt_eng_map[vec] |= BIT_ULL(i);
> > +		val = rvu_read64(rvu, blkaddr, CPT_AF_EXEX_STS(eng));
> > +		if ((val & 0x2) || (!(val & 0x2) && (val & 0x1)))
> 
> I would say that this "if" is equal to (val & 0x2 || val & 0x1)
> 
Ack, thanks.

> Thanks