netdev - Re: [PATCH net-next v7] net: ngbe: Add ngbe mdio bus driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y74euxqQUpXR6OGZ@lunn.ch>
Date:   Wed, 11 Jan 2023 03:28:11 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Mengyuan Lou <mengyuanlou@...-swift.com>, netdev@...r.kernel.org,
        jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next v7] net: ngbe: Add ngbe mdio bus driver.

On Tue, Jan 10, 2023 at 06:19:07PM -0800, Jakub Kicinski wrote:
> On Mon, 9 Jan 2023 17:49:12 +0100 Andrew Lunn wrote:
> > On Mon, Jan 09, 2023 at 11:35:08PM +0800, Mengyuan Lou wrote:
> > > Add mdio bus register for ngbe.
> > > The internal phy and external phy need to be handled separately.
> > > Add phy changed event detection.
> > > 
> > > Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>  
> > 
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> Any preference on this getting merged as is vs Mengyuan implementing
> the c45 support via separate callbacks? I just applied the patches
> adding the new callbacks to net-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=ef1757ef58467310a285e57e6dbf6cf8314e5080

Hi Jakub

Thanks for merging these patches. I forget how many patches there are
in total, something like 60, so there are a few more series to
come. Many more drivers still need splitting.

If Mengyuan wants to split C22 and C45 that would be nice, but since
this is a new requirement, i would not insist on it.

  Andrew