netdev - Re: [PATCH v2 04/24] page_pool: Convert page_pool_release_page() to page_pool_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWjK9nrvsL0sVrwdYsmqhiBXU-9WRZ4B+tGPtk+8qrkknQw@mail.gmail.com>
Date:   Wed, 11 Jan 2023 15:56:17 +0200
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Jesper Dangaard Brouer <hawk@...nel.org>, netdev@...r.kernel.org,
        linux-mm@...ck.org, Shakeel Butt <shakeelb@...gle.com>
Subject: Re: [PATCH v2 04/24] page_pool: Convert page_pool_release_page() to page_pool_release_netmem()

On Tue, 10 Jan 2023 at 20:47, Matthew Wilcox <willy@...radead.org> wrote:
>
> On Tue, Jan 10, 2023 at 11:28:10AM +0200, Ilias Apalodimas wrote:
> > > -static inline void page_pool_release_page(struct page_pool *pool,
> > > -                                     struct page *page)
> > > +static inline void page_pool_release_netmem(struct page_pool *pool,
> > > +                                     struct netmem *nmem)
> > >  {
> > >  }
> > >
> > > @@ -378,6 +378,12 @@ static inline void page_pool_put_page_bulk(struct page_pool *pool, void **data,
> > >  }
> > >  #endif
> > >
> >
> > I think it's worth commenting here that page_pool_release_page() is
> > eventually going to be removed once we convert all drivers and shouldn't
> > be used anymore
>
> OK.  How about I add this to each function in this category:
>
> /* Compat, remove when all users gone */
>
> and then we can find them all by grepping for 'Compat'?

Yep that's fine

Thanks
/Ilias