netdev - Re: [RFC PATCH net-next 0/7] NIC driver Rx ring ECN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230111104618.74022e83@kernel.org>
Date:   Wed, 11 Jan 2023 10:46:18 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     jgh@...hat.com
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next 0/7] NIC driver Rx ring ECN

On Wed, 11 Jan 2023 14:34:20 +0000 jgh@...hat.com wrote:
> Stats counters are incremented in ipv4 and ipv6 input processing,
> with results:
> 
>  $ nstat -sz *Congest*
>  #kernel
>  Ip6InCongestionPkts             0                  0.0
>  IpExtInCongestionPkts           148454             0.0
>  $ 

Do you have any reason to believe that it actually helps anything?
NAPI with typical budget of 64 is easily exhausted (you just need 
two TSO frames arriving at once with 1500 MTU).

Host level congestion is better detected using time / latency signals.
Timestamp the packet at the NIC and compare the Rx time to current time
when processing by the driver. 

Google search "Google Swift congestion control".