netdev - Re: [PATCH] caif: don't assume iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <507593a5-3606-8a92-e599-dd8711df519e@kernel.dk>
Date:   Wed, 11 Jan 2023 14:58:23 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Keith Busch <kbusch@...a.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, io-uring@...r.kernel.org,
        linux-kernel@...r.kernel.org, Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH] caif: don't assume iov_iter type

On 1/11/23 11:42 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@...nel.org>
> 
> The details of the iov_iter types are appropriately abstracted, so
> there's no need to check for specific type fields. Just let the
> abstractions handle it.
> 
> This is preparing for io_uring/net's io_send to utilize the more
> efficient ITER_UBUF.

Looks good to me - the correct return here would be -EFAULT as well,
not -EINVAL. Which is what will happen once memcpy_from_msg() is
called anyway.

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe