netdev - Re: KSZ8795 incorrect bit definitions for static MAC table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <506f2c24-6bad-b378-741f-42c13b079526@mcqueen.au>
Date:   Wed, 11 Jan 2023 14:52:50 +1100
From:   Craig McQueen <craig@...ueen.au>
To:     netdev <netdev@...r.kernel.org>
Subject: Re: KSZ8795 incorrect bit definitions for static MAC table

In my previous message, I said

 > Note that the ksz8863_masks[] change has not been tested, but it 
looks right from a read of the data sheet.

However, I didn't actually include the change for that. Reading the data 
sheets, it looks as though it would need:



diff --git a/drivers/net/dsa/microchip/ksz8795.c 
b/drivers/net/dsa/microchip/ksz8795.c
index 16b546ad0cd3..3c6fee9db038 100644
--- a/drivers/net/dsa/microchip/ksz8795.c
+++ b/drivers/net/dsa/microchip/ksz8795.c
@@ -105,8 +105,8 @@ static const u32 ksz8863_masks[] = {
         [STATIC_MAC_TABLE_VALID]        = BIT(19),
         [STATIC_MAC_TABLE_USE_FID_R]    = BIT(21),
         [STATIC_MAC_TABLE_USE_FID_W]    = BIT(21),
-       [STATIC_MAC_TABLE_FID_R]        = GENMASK(29, 26),
-       [STATIC_MAC_TABLE_FID_W]        = GENMASK(29, 26),
+       [STATIC_MAC_TABLE_FID_R]        = GENMASK(25, 22),
+       [STATIC_MAC_TABLE_FID_W]        = GENMASK(25, 22),
         [STATIC_MAC_TABLE_OVERRIDE]     = BIT(20),
         [STATIC_MAC_TABLE_FWD_PORTS]    = GENMASK(18, 16),
         [DYNAMIC_MAC_TABLE_ENTRIES_H]   = GENMASK(5, 0),