netdev - Re: [patch net-next v4 00/10] devlink: linecard and reporters locking cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcc5e230-f50d-486f-9f01-b9c7d52efda0@intel.com>
Date:   Wed, 11 Jan 2023 16:12:23 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <michael.chan@...adcom.com>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
        <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <tariqt@...dia.com>, <saeedm@...dia.com>, <leon@...nel.org>,
        <idosch@...dia.com>, <petrm@...dia.com>,
        <mailhol.vincent@...adoo.fr>, <gal@...dia.com>
Subject: Re: [patch net-next v4 00/10] devlink: linecard and reporters locking
 cleanup



On 1/11/2023 1:07 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> This patchset does not change functionality.
> 
> Patches 1-6 removes linecards and reporters locks and reference counting,
> converting them to be protected by devlink instance lock as the rest of
> the objects.
> 
> Patches 7 and 8 convert linecards and reporters dumpit callbacks to
> recently introduced devlink_nl_instance_iter_dump() infra.
> Patch 9 removes no longer needed devlink_dump_for_each_instance_get()
> helper.
> 
> The last patch adds assertion to devl_is_registered() as dependency on
> other locks is removed.
> 
> ---

I think you said a v5 would be posted rebased on top of Kuba's fix, but
the whole series looks good to me.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> v3->v4:
> - patch #1 was removed from the set and will be sent as a part of
>   another patchset
> v2->v3:
> - see individual patches for changelog, mainly original patch #4 was
>   split into 3 patches for easier review
> v1->v2:
> - patch 7 bits were unsquashed to patch 8
> 
> 
> Jiri Pirko (10):
>   devlink: remove linecards lock
>   devlink: remove linecard reference counting
>   devlink: protect health reporter operation with instance lock
>   devlink: remove reporters_lock
>   devlink: remove devl_port_health_reporter_destroy()
>   devlink: remove reporter reference counting
>   devlink: convert linecards dump to devlink_nl_instance_iter_dump()
>   devlink: convert reporters dump to devlink_nl_instance_iter_dump()
>   devlink: remove devlink_dump_for_each_instance_get() helper
>   devlink: add instance lock assertion in devl_is_registered()
> 
>  .../ethernet/mellanox/mlx5/core/en/health.c   |  12 +
>  .../mellanox/mlx5/core/en/reporter_rx.c       |   6 +-
>  .../mellanox/mlx5/core/en/reporter_tx.c       |   6 +-
>  drivers/net/ethernet/mellanox/mlxsw/core.c    |   8 +-
>  .../ethernet/mellanox/mlxsw/core_linecards.c  |   8 +-
>  drivers/net/netdevsim/health.c                |  20 +-
>  include/net/devlink.h                         |  26 +-
>  net/devlink/core.c                            |   4 -
>  net/devlink/devl_internal.h                   |  20 +-
>  net/devlink/leftover.c                        | 428 +++++++-----------
>  net/devlink/netlink.c                         |  12 +-
>  11 files changed, 213 insertions(+), 337 deletions(-)
>