netdev - Re: [net-next] ipv6: remove max_size check inline with ipv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 09:06:39 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jon Maxwell <jmaxwell37@...il.com>, davem@...emloft.net
Cc:     oe-kbuild-all@...ts.linux.dev, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, martin.lau@...nel.org, joel@...lfernandes.org,
        paulmck@...nel.org, eyal.birger@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jon Maxwell <jmaxwell37@...il.com>,
        Andrea Mayer <andrea.mayer@...roma2.it>
Subject: Re: [net-next] ipv6: remove max_size check inline with ipv4

Hi Jon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Jon-Maxwell/ipv6-remove-max_size-check-inline-with-ipv4/20230112-053517
patch link:    https://lore.kernel.org/r/20230111213306.265239-1-jmaxwell37%40gmail.com
patch subject: [net-next] ipv6: remove max_size check inline with ipv4
config: m68k-allmodconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/6fb29b5595df9235f531daa3af1ab4aebf0c1834
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jon-Maxwell/ipv6-remove-max_size-check-inline-with-ipv4/20230112-053517
        git checkout 6fb29b5595df9235f531daa3af1ab4aebf0c1834
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/ipv6/route.c: In function 'ip6_dst_gc':
>> net/ipv6/route.c:3298:23: error: 'gc_thresh' undeclared (first use in this function)
    3298 |         if (entries > gc_thresh)
         |                       ^~~~~~~~~
   net/ipv6/route.c:3298:23: note: each undeclared identifier is reported only once for each function it appears in


vim +/gc_thresh +3298 net/ipv6/route.c

  3286	
  3287	static void ip6_dst_gc(struct dst_ops *ops)
  3288	{
  3289		struct net *net = container_of(ops, struct net, ipv6.ip6_dst_ops);
  3290		int rt_min_interval = net->ipv6.sysctl.ip6_rt_gc_min_interval;
  3291		int rt_elasticity = net->ipv6.sysctl.ip6_rt_gc_elasticity;
  3292		int rt_gc_timeout = net->ipv6.sysctl.ip6_rt_gc_timeout;
  3293		unsigned long rt_last_gc = net->ipv6.ip6_rt_last_gc;
  3294		unsigned int val;
  3295		int entries;
  3296	
  3297		entries = dst_entries_get_fast(ops);
> 3298		if (entries > gc_thresh)
  3299			entries = dst_entries_get_slow(ops);
  3300	
  3301		if (time_after(rt_last_gc + rt_min_interval, jiffies))
  3302			goto out;
  3303	
  3304		fib6_run_gc(atomic_inc_return(&net->ipv6.ip6_rt_gc_expire), net, true);
  3305		entries = dst_entries_get_slow(ops);
  3306		if (entries < ops->gc_thresh)
  3307			atomic_set(&net->ipv6.ip6_rt_gc_expire, rt_gc_timeout >> 1);
  3308	out:
  3309		val = atomic_read(&net->ipv6.ip6_rt_gc_expire);
  3310		atomic_set(&net->ipv6.ip6_rt_gc_expire, val - (val >> rt_elasticity));
  3311	}
  3312	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (278740 bytes)