netdev - Re: [PATCH v8 03/25] net/ethtool: add ULP_DDP_{GET,SET} operations for caps and stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2535ydatt91.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Fri, 13 Jan 2023 16:16:10 +0200
From:   Aurelien Aptel <aaptel@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "sagi@...mberg.me" <sagi@...mberg.me>, "hch@....de" <hch@....de>,
        "kbusch@...nel.org" <kbusch@...nel.org>,
        "axboe@...com" <axboe@...com>,
        Chaitanya Kulkarni <chaitanyak@...dia.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "aurelien.aptel@...il.com" <aurelien.aptel@...il.com>,
        Shai Malin <smalin@...dia.com>,
        "malin1024@...il.com" <malin1024@...il.com>,
        Or Gerlitz <ogerlitz@...dia.com>,
        Yoray Zack <yorayz@...dia.com>,
        Boris Pismenny <borisp@...dia.com>
Subject: Re: [PATCH v8 03/25] net/ethtool: add ULP_DDP_{GET,SET} operations
 for caps and stats

Jakub Kicinski <kuba@...nel.org> writes:
> The standard ethtool interface should expose the accumulated stats.
> The stats of finer granularity need to be reported on the object to
> which they are scoped.
>
> I'm still yet to find any practical use for per-queue stats in
> production.
>
> IOW report the cumulative per device stats in ethtool -I --your-switch.
> The per-queue stats can go to ethtool -S until someone actually finds
> a good reason to read them in production..

We currently don't have justifications for the per queue stats,
hence we will move it out of the series at this point. We might
reconsider it in the future.

We'll continue with your suggestion with global dynamic strings to
avoid having the need to update ethtool with the additional counters
we are planning to add as part of the incremental features (TX, target
mode, ...).

Thanks