netdev - Re: [PATCH net] rxrpc: Fix wrong error return in rxrpc_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230113113959.75b0fe38@kicinski-fedora-PC1C0HJN>
Date:   Fri, 13 Jan 2023 11:40:08 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Howells <dhowells@...hat.com>
Cc:     netdev@...r.kernel.org, Marc Dionne <marc.dionne@...istor.com>,
        Dan Carpenter <error27@...il.com>,
        kernel test robot <lkp@...el.com>,
        syzbot+4bb6356bb29d6299360e@...kaller.appspotmail.com,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix wrong error return in
 rxrpc_connect_call()

On Wed, 11 Jan 2023 18:07:15 +0000 David Howells wrote:
> Fix rxrpc_connect_call() to return -ENOMEM rather than 0 if it fails to
> look up a peer.
> 
> This generated a smatch warning:
>         net/rxrpc/call_object.c:303 rxrpc_connect_call() warn: missing error code 'ret'
> 
> I think this also fixes a syzbot-found bug:
> 
>         rxrpc: Assertion failed - 1(0x1) == 11(0xb) is false
>         ------------[ cut here ]------------
>         kernel BUG at net/rxrpc/call_object.c:645!
> 
> where the call being put is in the wrong state - as would be the case if we
> failed to clear up correctly after the error in rxrpc_connect_call().

Applied, thanks!