netdev - Re: [PATCH iproute2-next 2/2] tc: add new attr TCA_EXT_WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8D4NhoRnAIz7XBX@Laptop-X1>
Date:   Fri, 13 Jan 2023 14:20:38 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH iproute2-next 2/2] tc: add new attr TCA_EXT_WARN_MSG

On Thu, Jan 12, 2023 at 08:30:19PM -0800, Stephen Hemminger wrote:
> On Fri, 13 Jan 2023 11:46:17 +0800
> Hangbin Liu <liuhangbin@...il.com> wrote:
> 
> > 	if (tb[TCA_EXT_WARN_MSG]) {
> > +		print_string(PRINT_ANY, "Warn", "%s ", rta_getattr_str(tb[TCA_EXT_WARN_MSG]));
> > +		print_nl();
> > +	}
> > +
> 
> Errors should go to stderr, and not to stdout. And no JSON support please.

Thanks, I thought this belongs to an attr data. So I put it in the JSON object.
I will adjust this to stderr and out side of JSON.

Hangbin