netdev - Re: [PATCH net-next 2/2] net: hns3: add vf fault process in hns3 ras

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8D/dXTBxrLOwmgc@unreal>
Date:   Fri, 13 Jan 2023 08:51:33 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Hao Lan <lanhao@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, yisen.zhuang@...wei.com,
        salil.mehta@...wei.com, edumazet@...gle.com, pabeni@...hat.com,
        richardcochran@...il.com, shenjian15@...wei.com,
        wangjie125@...wei.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: hns3: add vf fault process in hns3 ras

On Fri, Jan 13, 2023 at 10:08:29AM +0800, Hao Lan wrote:
> From: Jie Wang <wangjie125@...wei.com>
> 
> Currently hns3 driver supports vf fault detect feature. Several ras caused
> by VF resources don't need to do PF function reset for recovery. The driver
> only needs to reset the specified VF.
> 
> So this patch adds process in ras module. New process will get detailed
> information about ras and do the most correct measures based on these
> accurate information.
> 
> Signed-off-by: Jie Wang <wangjie125@...wei.com>
> Signed-off-by: Hao Lan <lanhao@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hnae3.h   |   1 +
>  .../hns3/hns3_common/hclge_comm_cmd.h         |   1 +
>  .../hisilicon/hns3/hns3pf/hclge_err.c         | 113 +++++++++++++++++-
>  .../hisilicon/hns3/hns3pf/hclge_err.h         |   2 +
>  .../hisilicon/hns3/hns3pf/hclge_main.c        |   3 +-
>  .../hisilicon/hns3/hns3pf/hclge_main.h        |   1 +
>  6 files changed, 115 insertions(+), 6 deletions(-)

Why is it good idea to reset VF from PF?
What will happen with driver bound to this VF?
Shouldn't PCI recovery handle it?

Thanks