netdev - Re: [PATCH net-next] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 14 Jan 2023 21:45:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Siddharth Vadapalli <s-vadapalli@...com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, linux@...linux.org.uk,
        pabeni@...hat.com, rogerq@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        vigneshr@...com, srk@...com, s-vadapalli@...com
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS
 release action

Hi Siddharth,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Siddharth-Vadapalli/net-ethernet-ti-am65-cpsw-cpts-Fix-CPTS-release-action/20230113-184939
patch link:    https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli%40ti.com
patch subject: [PATCH net-next] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
config: arm64-defconfig
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/70ed560865f27e8684621a6868af6c20c1e3f438
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Siddharth-Vadapalli/net-ethernet-ti-am65-cpsw-cpts-Fix-CPTS-release-action/20230113-184939
        git checkout 70ed560865f27e8684621a6868af6c20c1e3f438
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/ti/am65-cpsw-nuss.c: In function 'am65_cpsw_cpts_cleanup':
>> drivers/net/ethernet/ti/am65-cpsw-nuss.c:1919:17: error: implicit declaration of function 'am65_cpts_release'; did you mean 'am65_cpts_resume'? [-Werror=implicit-function-declaration]
    1919 |                 am65_cpts_release(common->cpts);
         |                 ^~~~~~~~~~~~~~~~~
         |                 am65_cpts_resume
   cc1: some warnings being treated as errors


vim +1919 drivers/net/ethernet/ti/am65-cpsw-nuss.c

  1915	
  1916	static void am65_cpsw_cpts_cleanup(struct am65_cpsw_common *common)
  1917	{
  1918		if (common->cpts)
> 1919			am65_cpts_release(common->cpts);
  1920	}
  1921	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (274890 bytes)