netdev - Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 Jan 2023 14:13:44 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Lizhe <sensor1010@....com>
Cc:     kvalo@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, johannes.berg@...el.com,
        alexander@...zel-home.de, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm_kmalloc replaces
 kmalloc

On Fri, Jan 13, 2023 at 06:12:31AM -0800, Lizhe wrote:
> use devm_kmalloc replaces kmalloc

No, it is not.

> 
> Signed-off-by: Lizhe <sensor1010@....com>
> ---
>  drivers/net/wireless/atmel/at76c50x-usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
> index 009bca34ece3..f486ddb83d46 100644
> --- a/drivers/net/wireless/atmel/at76c50x-usb.c
> +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
> @@ -2444,7 +2444,7 @@ static int at76_probe(struct usb_interface *interface,
>  
>  	udev = usb_get_dev(interface_to_usbdev(interface));
>  
> -	fwv = kmalloc(sizeof(*fwv), GFP_KERNEL);
> +	fwv = devm_kmalloc(sizeof(*fwv), GFP_KERNEL);
>  	if (!fwv) {
>  		ret = -ENOMEM;
>  		goto exit;
> @@ -2535,7 +2535,6 @@ static int at76_probe(struct usb_interface *interface,
>  		at76_delete_device(priv);
>  
>  exit:
> -	kfree(fwv);
>  	if (ret < 0)
>  		usb_put_dev(udev);
>  	return ret;
> -- 
> 2.17.1
>